ffmpeg adapter: added support for processing all subtitle streams

phiresky / ripgrep-all

rga: ripgrep, but also search in PDFs, E-Books, Office documents, zip, tar.gz, etc.

Other

6.4k stars 148 forks source link

ffmpeg adapter: added support for processing all subtitle streams #172

Closed prj-2501 closed 1 year ago

prj-2501 commented 1 year ago

ffprobe supports enumerating all indices of subtitle streams. Use this for processing all subtitle streams.

Useful when the first (default) stream does not include full captions and/or is not in the expected language.

phiresky commented 1 year ago

neat. do you happen to have a test file you could add to the repo and add a small test for?

prj-2501 commented 1 year ago

I can probably reuse the wasteland.mkv file for the test but do we really want to verify both metadata and subtitles? Given that the metadata output comes from ffprobe.

phiresky commented 1 year ago

i guess it's fine