Fix installation and CI

phiresky / ripgrep-all

rga: ripgrep, but also search in PDFs, E-Books, Office documents, zip, tar.gz, etc.

Other

8.21k stars 177 forks source link

Fix installation and CI #92

Closed TriplEight closed 3 years ago

TriplEight commented 3 years ago

Fixes installation with the stable toolchain. Essentially it's just cargo update
Fixes the push pipeline, now it fails on a test
Fixes the release pipeline

TriplEight commented 3 years ago

Had to get rid of msvc test and windows altogether because didn't decide how to install poppler there.

phiresky commented 3 years ago

Why does the CI need to have poppler at all?

TriplEight commented 3 years ago

Why does the CI need to have poppler at all?

Because otherwise, CI will fail the test which relies on pdftotext binary. If there's a Rust implementation of pdftotext it would be a way better to use that one mentioning it in the dependencies.

TriplEight commented 3 years ago

win-msvc test fails with https://github.com/phiresky/ripgrep-all/runs/1621230957#step:11:241 win-gnu build fails with https://github.com/phiresky/ripgrep-all/pull/92/checks?check_run_id=1625639166#step:9:566

I'm removing windows CI steps to make this PR mergeable and address the issues later.

TriplEight commented 3 years ago

@phiresky anything you want to add before merging?

phiresky commented 3 years ago

It's fine if we don't run the tests on Windows, but we do need the windows build in CI

jounathaen commented 3 years ago

I'd like to give this a little bump, as this one prevents me from installing rga via cargo :slightly_smiling_face:

TriplEight commented 3 years ago

@phiresky there are no changes to release, it's just fixed