search

phistrom / auto-bogons

Automatically update a BOGONs address list in Mikrotik RouterOS
MIT License
4 stars 2 forks source link

:do ... while typo #1

Closed nullmem closed 3 years ago

nullmem commented 3 years ago

https://github.com/phistrom/auto-bogons/blob/64ea0d54d9014bb6417037c3703e8f4b713501b9/bogon-updater.rsc#L57

should be:

} while=($lineEnd < $contentLen - 2)

phistrom commented 3 years ago

Thank you. You're absolutely correct, the Scripting documentation on the Mikrotik Wiki clearly shows an equals sign after the while in a ":do ... while" loop.

I've been using this script in production without issue for quite some time. Commit 0faf1be fixes this typo though.

Out of curiosity, was there a particular version of RouterOS where this typo caused the script to fail?