phiz71 / vertx-swagger

Swagger integration in Eclipse Vert.X world. A dynamic Vert.X router, configured with a swagger file and a swagger-codegen plugin to generate a server stub.
Apache License 2.0
86 stars 35 forks source link

Move MainApiException and MainApiHeader #87

Closed phiz71 closed 7 years ago

phiz71 commented 7 years ago

@javadch : I think you will like this PR ;)

javadch commented 7 years ago

The ResourceResponse class has an import: io.swagger.server.api.MainApiHeader. This is wrong, while I have provided a custom package name during code generation. The MainApiHeader is in the right custom package, but the import is wrong. It affects all the calls to the ResourceResponse.addHeader methods. I have not checked other files!

phiz71 commented 7 years ago

oops, I've hardcoded io.swagger.server.api.MainApiHeader in the ResourceResponse template 😓 . Instead of using {{invokerPackage}}.. Sorry ^^

javadch commented 7 years ago

Let me know when you committed the fix ;-)

phiz71 commented 7 years ago

@javadch : Just in case you did not see. I've fixed. You can check here --> https://github.com/phiz71/vertx-swagger/commit/3a6025b5341eb365005711560525d3106fcb9e68