phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

Create V.2 Filter #215

Closed dibleauzah closed 1 year ago

dibleauzah commented 2 years ago

Is your feature request related to a problem? Please describe. As a PHLASK user, I need to be able to filter the PHLASK map by PHLASK tap attributes.

Describe the solution you'd like

Describe alternatives you've considered N/A--TBD

Additional context: Already outlined in FilterDrawer.js This should be built using the Material-UI Drawer component: https://mui.com/material-ui/react-drawer/ Refer to the PHLASK team library [Figma](https://www.figma.com/file/l0lBzwPalGUg6JjcOXD2Xs/PHLASK--team-library?type=design&node-id=852%3A40805&t=tIJrPuOTV2hLlaRs-1)

edlopez000 commented 2 years ago

Additional notes:

edlopez000 commented 2 years ago

@caseyvaughn Any updates on this ticket?

affabillyty commented 2 years ago

Hey @caseyvaughn , following up here on @edlopez000 's comment - do you need any support for this? Are you still interested in pursuing this ticket? We can certainly loop in @tnguyen21 or @gcardonag if some problem solving would help.

gcardonag commented 2 years ago

As an additional (but not required) note, we'd like to have the filter panel pop-in from the right on Desktop

hannarosenfeld commented 2 years ago

Hi, I am currently working on this. I created the filter drawer according to the template on figma, but the actual filters are not hooked up yet. I will work on that over the next two weeks.

link to design template on figma

affabillyty commented 1 year ago

There are buttons on the drawer, and when you click on the buttons the interface is filtering based on that filter.

Cited example with: when filtering for "Open Now" taps, the map displays only the locations that are open based on time

freelyPheobe commented 1 year ago

Hey @jordanforbes, is this an active ticket? Is this something that's in progress or not? Are there any impediments or general support needed? We're trying to clean up tickets and updates...

jordanforbes commented 1 year ago

@freelyPheobe yes it is, I'm still working on it. The main issue is that the filters weren't included in the redux state, but we discussed that at the meeting last night so hopefully this will be fixed. In addition some css needs to be tweaked.

jordanforbes commented 1 year ago

Also it's currently just buttons and not a form. As a result the apply and clear buttons currently do nothing.

jordanforbes commented 1 year ago

But the main intended function of filtering places using a redux state change does work.

CmonUlot commented 1 year ago

Just updated the Figma link; each Resource's filter is laid out. There are a few changes with the copy.

freelyPheobe commented 1 year ago

@jordanforbes, is there any code you can share with a new developer working on this ticket?