search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 34 forks source link

Create V.2 MapMarkers #224

Closed dibleauzah closed 3 weeks ago

dibleauzah commented 2 years ago

Is your feature request related to a problem? Please describe. As we prepare to deploy PHLASK 2.0, we would like to update our markers to use the new designs prepared by our design team.

Describe the solution you'd like We would like the map markers displayed for all of our resources to match the designs listed here: https://www.figma.com/file/VGGqwl3Eq3GQIAO9I6LoNW/PHLASK?node-id=4550%3A31103&t=rE3z6jHsaxqt5JTG-1

Describe alternatives you've considered n/a

Additional context n/a

affabillyty commented 2 years ago

Note to self: displaying the PHLASK Tap pins on the map

lisapancakes commented 2 years ago

The map pins have not been designed yet. If you want to start on this, I suggest removing the differently colored phlask-icons for water taps and implementing the following pins only:

gcardonag commented 1 year ago

As a part of this, we would like to also be able to render Foraging and Bathroom-type data on the map. We'll need to add new IndieXMarker-type and MapMarkersX-type Components to handle those two cases. We can follow the similarly-named components in the project as a starting point and add references to the MapMarkersX-type components to the MapMarkersMapper component.

tomporvaz commented 9 months ago

Daniel Cha is picking this ticket up but does not have a github account in project yet.

tomporvaz commented 9 months ago

SVGs of the pins are in this google drive folder, and the filenames begin with pin.

tomporvaz commented 8 months ago

@a-maci29 to help @DancyyDev navigate code

DancyyDev commented 8 months ago

For the food icons, there are many different icons that pop up, are we consolidating all the food icons into one icon? @tomporvaz @freelyPheobe

tomporvaz commented 7 months ago

Needs help from design.

tomporvaz commented 7 months ago

@gcardonag to add bathroom and foraging data to test dbs for testing purposes.

freelyPheobe commented 6 months ago

So far, everything is running smoothly. Image being replaced for foraging and database needs to still be connected.

tomporvaz commented 6 months ago

working on adding the active pin as well.

tomporvaz commented 5 months ago

Half complete. Foraging and Bathroom pins are not added yet, and these types cannot be verified without data. This work can continue when #399 is complete.

tomporvaz commented 4 months ago

Still blocked, but a big PR related to the Data schema coming soon may resolve this issue, or at least unblock it.

gcardonag commented 3 weeks ago

Hey @DancyyDev ! We're just digging through some of our v2 ticket backlog and saw this. Is there any help/support you'd like with the work you've been doing here?

gcardonag commented 3 weeks ago

@DancyyDev disregard this! We'll close this in favor of https://github.com/phlask/phlask-map/issues/386 (but offer is still open to support!)