An X that closes the filter modal

phlask / phlask-map

Code behind the Phlask Web Map

33 stars 34 forks source link

An X that closes the filter modal #363

Closed tomporvaz closed 2 months ago

tomporvaz commented 5 months ago

Is your feature request related to a problem? Please describe. The filter menu should have an X in the top right to close the modal. Screenshot from 2023-12-28 12-21-24 https://www.figma.com/file/VGGqwl3Eq3GQIAO9I6LoNW/PHLASK?type=design&node-id=8303-156456&mode=design&t=vVRkRN4MSA1SQjJY-4

Describe the solution you'd like an X that closes the filter modal

Describe alternatives you've considered n/a

Additional context Issue #215 and #304

tomporvaz commented 4 months ago

Should be assigned to Alex.

affabillyty commented 3 months ago

Hey @tomporvaz and @JosephAni , was this the ticket that Joseph briefly was helping newcomer Andrew with? If so, I think this needs to move back to "Ready" and be reassigned, unless Joe is planning to pick it up himself and continue with it

JosephAni commented 3 months ago

A close icon button was added to the filter. Pls review.

tomporvaz commented 3 months ago

PR #397

tomporvaz commented 2 months ago

@RNR1 I don't see the close button on the filter in Beta. Is there another step, or do you think other code might have overwritten Joe's changes?