search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

filter does not update map for water cooler or other not implemented types #370

Closed tomporvaz closed 2 months ago

tomporvaz commented 10 months ago

Describe the bug When I choose a filter that has no data, nothing changes on the screen. For example, as demonstrated in the recording below, I choose a water filter of soda machine, but there is no change of which pins are displayed. This could indicate that all pins rendered are soda machines, but I think this is highly unlikely. I think it is more likely that soda machines is not an implemented tag, and the null result from this query is affecting no change.

To Reproduce

https://github.com/phlask/phlask-map/assets/45155555/5f019746-2588-42cb-bd48-06651912083e

Expected behavior The map should show no pins or an error message to indicate that there are no results matching that filter.

Screenshots n/a

Desktop (please complete the following information): n/a

Smartphone (please complete the following information): n/a

Additional context Feature implemented in #215 and solution may be related to #344

vontell commented 5 months ago

This will be part of my new data schema PR #433

tomporvaz commented 5 months ago

@vontell is making a big PR related to the new data schema that will address this issue soon.