search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

[DRAFT] Refine our approach to reducers #432

Open gcardonag opened 6 months ago

gcardonag commented 6 months ago

Is your feature request related to a problem? Please describe. Based on the conversation at https://github.com/phlask/phlask-map/pull/407/files#r1595458040, we would like to reevaluate how we approach reducers in our code.

We would not expect this to change the visual or functional behavior of the site, its more of an internal cleanup to make the code look nicer.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

ravicodelabs commented 3 months ago

I think it's a good idea to do this! In particular, thesrc/reducers/filterMarkers.js reducer is currently being used for more than just actions related to filtering. Hence, we could rename this file and/or reorganize the reducers so that the naming reflects the content/behavior.