search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

Pins blink on toolbar icon clicks on desktop and mobile #441

Open ravicodelabs opened 5 months ago

ravicodelabs commented 5 months ago

When one clicks some of the Toolbar icons (e.g. Add Site, Search, or the Filter), the map pins blink briefly. On mobile they only blink on the first click, but then will blink again if clicking a different toolbar and coming back to the first one.

The bug seems to have appeared in commit a489447d8f3468eaf6787bdff4aca0d904bd818e.

Expected behavior

There should be no blinking of pins when toolbar icons are clicked.

hunxjunedo commented 5 months ago

Hey @ravicodelabs can I get assigned ?

ravicodelabs commented 5 months ago

Hey @hunxjunedo, I'm actually not sure what the process for that would be here, and another team member may be able to help with that. cc: @tomporvaz.

However, feel free to fork and debug there and leave any thoughts/findings here for discussion if applicable.

Thank you for your interest!

vontell commented 5 months ago

I think @RNR1 and I were discussing blinking issues in the last meeting as well - this might be fixed by our work on the markers, so I'll add a comment this weekend when I'll be working on my PR 👍