search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

Update devcontainer.json #514

Closed ravicodelabs closed 3 months ago

ravicodelabs commented 3 months ago

Updates the devcontainer.json file for both GitHub Codespaces as well as local VS Code docker setups (when devcontainer.json is being used). This shouldn't change much for folks using these tools already, but some improvements are made on the devcontainer.json.

ravicodelabs commented 3 months ago

Approved ✅

Before merging, and for the benefit of folks who may review this PR in the future, what was the goal of these improvements?

The startup speed seems similar at a glance, but I recall talking to you about improvements for local dev where it may have not been working.

Ah yes, the main goal here was to address an issue where the prior image would not work on an M processor based MacBook, as their was a conflict in the 'universal' image which did not allow the interoperability.

Regarding the fix: the configuration was updated to use a 'javascript-node' image rather than 'universal', which doesn't have the problematic dependency, and node is sufficient for our code base.

gcardonag commented 3 months ago

Approved ✅

Before merging, and for the benefit of folks who may review this PR in the future, what was the goal of these improvements?

The startup speed seems similar at a glance, but I recall talking to you about improvements for local dev where it may have not been working.

Ah yes, the main goal here was to address an issue where the prior image would not work on an M processor based MacBook, as their was a conflict in the 'universal' image which did not allow the interoperability.

Regarding the fix: the configuration was updated to use a 'javascript-node' image rather than 'universal', which doesn't have the problematic dependency, and node is sufficient for our code base.

Thank you @ravicodelabs ! 😄