search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

Dynamic Width for Selected Tap Modal on Desktop #530

Open tomporvaz opened 2 months ago

tomporvaz commented 2 months ago

Describe the bug The selected tap modal expands beyond the bounds of the screen at lower screen widths. We'd like to make the Selected map modal dynamic so the max width is 708px but it should shrink to a smaller size when the modal expands beyond the bounds of the screen.

image

To Reproduce Use dev tools in responsive mode and set screen width to anywhere between 600px and 768px and notice how the details modal doesn't fit on the screen.

Expected behavior If the modal doesn't fit on the screen, then the app should display a narrower modal.

Solution Give the modal a dynamic width.

GV14982 commented 4 weeks ago

Hm, I'm having trouble reproducing this. When I do dynamic sizing and set it below 900px it auto switches to the mobile view. Do you have any additional info I might be missing?