phlegx / redmine_gitlab_hook

This plugin allows you to update your local Git repositories in Redmine when changes have been pushed to GitLab.
MIT License
218 stars 73 forks source link

the web_hook of gitlab7.1.1 using GET not POST #30

Closed hnuzhoulin closed 7 years ago

hnuzhoulin commented 7 years ago

I kown why I can using a restful tool to test web_hook successfully. Because I use POST in restful tools,but gitlab using GET, And in code: https://github.com/phlegx/redmine_gitlab_hook/blob/master/app/controllers/gitlab_hook_controller.rb#L10

it set only accept post.So I try to delete this if state.

But related problem is it can not work when I push until I click test hook button or run a GET/POST request in restful tool. I will try to find out why.

hnuzhoulin commented 7 years ago

I was confused.

my new redmine test environment,the same gitlab send POST not GET request..

hnuzhoulin commented 7 years ago

My redmine using https,and the web_hook,I forget to using https. another change is I change the repo from public to internal.

it using POST now.