phlegx / redmine_gitlab_hook

This plugin allows you to update your local Git repositories in Redmine when changes have been pushed to GitLab.
MIT License
218 stars 73 forks source link

Support multiple repositories in same redmine project #36

Closed jcppkkk closed 6 years ago

jcppkkk commented 6 years ago
phlegx commented 6 years ago

Hi @jcppkkk! Thank you for your pull request. Nice work!

Can you do the following please:

  1. Change all params['xxxxx'] to params[:xxxxx] if possible?
  2. We use unless instead of if not now. Line 134.
  3. Line 92 change "" to ''

Then we will merge your pull request. Thx! :smiley:

phlegx commented 6 years ago

Hi @jcppkkk! Thank you so much! :+1: :+1: :+1:

phlegx commented 6 years ago

@jcppkkk can you please add examples how you use the hook with multiple repositories in same redmine project?