search

phlex-ruby / phlex-markdown

MIT License
24 stars 2 forks source link

`template` method deprecation warning #8

Open spickermann opened 6 months ago

spickermann commented 6 months ago

When running the latest version of phlex-markdown with the latest version of phlex, then there is the following deprecation warning output:

⚠️ [DEPRECATION] Defining the `template` method on a Phlex component will not be supported in Phlex 2.0. Please rename the method to `view_template` instead.

Because phlex-markdown still uses the deprecated template method name at https://github.com/phlex-ruby/phlex-markdown/blob/ee1e2763fc842563577003a269982cfc4ac79006/lib/phlex/markdown.rb#L12

I am happy to open a PR to fix the issue but would need some guideline on how you would like to handle updating the method name and handling compatibility between the new version of phlex-markdown and different versions of phlex. Just change the dependency in phlex-markdown.gemspec to spec.add_dependency "phlex", ">= 1.10"?

spickermann commented 3 months ago

@joeldrapper I just noticed that there is already https://github.com/phlex-ruby/phlex-markdown/pull/7 which fixes this issue. Would it be possible to merge it and release a new version?