search

phlipper / chef-monit

Chef cookbook for monit package
http://phlippers.net/chef-monit
MIT License
67 stars 69 forks source link

apt cookbook include is problematic #77

Closed sonnysideup closed 5 years ago

sonnysideup commented 9 years ago

The metadata file suggests the apt cookbook rather than depending on it. This configuration makes sense since that cookbook is not needed when installing Monit from source (possibly binary as well). However, in the default recipe, we see an include_recipe "apt" call for any Debian platform regardless of the install strategy. Based on the layout of the recipes in this cookbook, users should use the default recipe and trigger different installs using attribute values instead of invoking the install_{source,package,binary} recipes directly.

Moving this include statement inside the install_package recipe remedies this problem without breaking existing functionality.

sonnysideup commented 9 years ago

@phlipper Should I do anything here to move this along?

sonnysideup commented 9 years ago

We're seeing errors in the test suites because the metadata.rb file suggests and does not depend on the "apt" and "yum-epel" cookbooks.

rickhull commented 9 years ago

this rationale makes sense to me, though I have not evaluated it in-depth. Just wanted to toss a few good feedback points your way. I am debian-oriented personally, though my job which involves this cookbook is RHEL/Centos based currently.