search

phluzern / shibboleth_auth

Fork of the TYPO3 extension shibboleth_auth for TYPO3 6.0+
1 stars 10 forks source link

AUTH_TYPE fix? #1

Open beriox opened 11 years ago

beriox commented 11 years ago

I've successfully tested your extension on Typo3 4.5.27 (and Tamer's original version, too).

As well as I did on the original extension, I had to modify two files in order to correctly recognize AUTH_TYPE, which on our organization is "Shibboleth" and not "shibboleth"... I used "strtolower" to fix this... Maybe it could be useful to include this change on the sources...

shibboleth_auth/pi1/class.tx_shibbolethauth_pi1.php: if (isset($_SERVER['AUTH_TYPE']) && strtolower($_SERVER['AUTH_TYPE']) == 'shibboleth') { shibboleth_auth/sv1/class.tx_shibbolethauth_sv1.php: return isset($_SERVER['AUTH_TYPE']) && ( strtolower($_SERVER['AUTH_TYPE']) == 'shibboleth') && !empty($this->remoteUser);

Have you already tried to contact Tamer Erdoğan to include these changes in a new release, and maybe to use github too, or http://forge.typo3.org/ ? I've also found other two projects for Shibboleth on Typo3 Forge, but I didn't test them yet.

lorenzulrich commented 10 years ago

I'm fine with this change. Could you create a pull request? Thanks. I'll write you an e-mail concerning the other questions.