search

phly / keep-a-changelog

Tools for manipulating CHANGELOG.md files in Keep A Changelog format, including tagging and releasing.
https://phly.github.io/keep-a-changelog/
BSD 2-Clause "Simplified" License
182 stars 23 forks source link

General fixes / improvements #51

Closed michalbundyra closed 5 years ago

michalbundyra commented 5 years ago

Hi @weierophinney !

I've prepared this PR with some general fixes / improvements. Please see that there is one commit which is BC break. Probably we can solve that another way, but I want you to have a look and decide how you want to resolve it.

There are also other issue I haven't fixed: in exceptions InvalidPullRequestException and NoMatchingChangelogDiscoveredException we have defined methods with name for, butfor` is PHP restricted keyword and it cannot be used to define method:

You cannot use any of the following words as constants, class names, function or method names. https://www.php.net/manual/en/reserved.keywords.php

Somehow we are not getting any issues, but I think it should be changed "just in case".

Each commit is small and described changed I've made.

weierophinney commented 5 years ago

Thanks, @webimpress! I have cherry-picked the commits that were still relevant following my changes in #51, and these are now in the master and develop trees for whenever I do the next release.