Closed Sergey-Vlasov closed 2 years ago
@daveaglick Would you be willing to look at a PR that adds VB support, in the same style as #146 ?
Yes, definitely - as with F# support I won't really be able to support it myself, but I'm happy to bring it in and add a disclaimer or follow-up in issues to that effect.
I suspect adding VB to be easier then F# since the compiler is the same. I don't know but would expect the following: 1 - VB uses TaskCommandLineEventArgs 2 - that would make the output format the same so you could use existing ProcessCscCommandLine
You could to look into the possibility of using the _cscCommandLineArguments and maybe rename it to _roslynCommandLineArguments
We would need a test version to confirm this, and a lot of MSBuild Structured Log Viewer 😂 My tip to anyone trying this: print all BuildMessageEventArgs in src/Buildalyzer/Logging/EventProcessor.cs a lot of data go's thru here and maybe the sourcefiles and references are already there, they just don't come from Csc or Fsc.
I wish you good luck!
I think this is resolved in #207 courtesy of @cslong - at a minimum an AnalyzerResult
is now created for Visual Basic projects (and tested via unit test). I'll close this issue since it's working as far as I can tell, but please open a new one if it looks like there are still problems with VB support (though my ability to help will be limited since I don't know the first thing about VB or VB projects).
With .NET 5 RC2 installed.
dotnet new console -lang VB
Actual output is:
Expected output: several SourceFiles and References.