search

phmonte / Buildalyzer

A utility to perform design-time builds of .NET projects without having to think too hard about it.
MIT License
589 stars 92 forks source link

Fixed a NullReferenceException for F# projects #216

Closed psfinaki closed 1 year ago

psfinaki commented 1 year ago

That big LINQ query started to throw for F# since the first cmd-line argument is a tuple (null, null). In tests, it's enough to just call SourceFiles.

daveaglick commented 1 year ago

Thanks for this! I'll hopefully be able to take a closer look in the next couple days.

psfinaki commented 1 year ago

@daveaglick, sure - thanks :)

psfinaki commented 1 year ago

A very gentle ping for a very small PR :)

psfinaki commented 1 year ago

@safesparrow FYI

daveaglick commented 1 year ago

Done! I know you've been waiting on this, and I didn't really have a chance to review it closely, so I'm trusting the test suite and just YOLO merged. I'll get a release out momentarily.

psfinaki commented 1 year ago

Thanks a lot, Dave :)

safesparrow commented 1 year ago

@safesparrow FYI

What is the PR about? Should I be excited? :) (I know nothing about the project, besides trying to use it for fsharp cracking)

psfinaki commented 1 year ago

@safesparrow - well just letting you know that I'm also trying to use it for some fsharp cracking :D

NREs are generally not a very exciting matter.