search

phmonte / Buildalyzer

A utility to perform design-time builds of .NET projects without having to think too hard about it.
MIT License
589 stars 92 forks source link

Support nullable context options #235

Closed Corniel closed 6 months ago

Corniel commented 10 months ago

I noticed that the NullableContextOptions where not set while creating the CSharpCompilationOptions. With this PR, that should be fixed.

Corniel commented 7 months ago

@daveaglick

You're loaded with work, that is pretty clear. How can I (we) help you?

daveaglick commented 7 months ago

@Corniel I appreciate the offer of help, and you're not wrong about being loaded :). My inclination is just to go ahead and pull down these PRs and merge them as long as tests pass locally. You've already done the heavy lifting by getting a PR open, and the feedback and involvement you had in #239 was a big help (it's always nice to have another set of eyes).

At the end of the day, I just need to find a couple hours to get back here and knock these things out. I do see a little relief on the horizon, so I'm hopeful I'll at least be able to merge the pending PRs and get a release out in the coming weeks. Please do feel free to ping me again if that doesn't happen!