search

phmonte / Buildalyzer

A utility to perform design-time builds of .NET projects without having to think too hard about it.
MIT License
589 stars 92 forks source link

Restore sorting empty target framework last #242

Closed 0xced closed 6 months ago

0xced commented 6 months ago

Commit 8e85a15e324a65f9da5033f3d8a2320c76dda378 dropped the NuGet.Frameworks dependency and as a result sorting of the target frameworks behaviour changed.

Previously, the NuGetFrameworkSorter would sort the empty target framework last. Since 8e85a15e324a65f9da5033f3d8a2320c76dda378 the empty target framework is sorted first.

This commit restores the old behaviour of sorting the empty target framework last.

Note: Stryker.NET was inadvertently depending on this behaviour, so v6.0.1 broke Stryker.NET. I have fixed the issue in Styker.NET but I think restoring the previous sorting behaviour is a good idea anyway.

daveaglick commented 6 months ago

Yikes, sorry! And good catch - nice work on bringing back a TargetFrameworkComparer that doesn't depend on NuGet.Frameworks. Merging and deploying a patch now.