search

phmonte / Buildalyzer

A utility to perform design-time builds of .NET projects without having to think too hard about it.
MIT License
589 stars 92 forks source link

Drop `BuildEventArgsReaderProxy` #258

Closed Corniel closed 3 months ago

Corniel commented 3 months ago

It is internal and seems not to be used at all. Unless, I'm mistaken, this is dead code.

Corniel commented 3 months ago

@daveaglick Can you confirm this, or explain why it still has purpose?

daveaglick commented 3 months ago

Interesting - it looks like I added it to provide access to some private stuff via reflection, but then I can't figure out where it was ever used from when looking through the commit history, let alone now. Wonder if I added it trying to work through something and then found another way but forgot to delete it.

Regardless, it doesn't look like the kind of thing that's intended to get picked up by some sort of reflection-based class discovery, so I think you're okay deleting it if there are no references.

Corniel commented 3 months ago

@daveaglick If you also can not think of any reason to keep this code, let just remove it.

Corniel commented 3 months ago

@phmonte I think it is safe to merge this one too.