search

phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

Add tool simid #173

Closed seliv55 closed 6 years ago

pcm32 commented 6 years ago

Hi @seliv55 what needs to happen is that all changes related to the addition of simid need to go in the same pull request, not all on separate pull requests.

For this you need to update your local copy of this repo (in particular the develop branch), branch from there to a feature/simid-addition (name is irrelevant of course, but if meaningful better) branch, put all your changes there, make sure it runs well on minikube locally, push that branch to this repo and then make a pull request, explaining what is the pull request about.

Thanks! Pablo

seliv55 commented 6 years ago

Hi @pcm32, thanks, I will do in this manner

pcm32 commented 6 years ago

Let me know if you need help with this. You could just for instance stand in one of your branches (possibly on the one used for this PR) and then cherry pick the changes in the other branches you created, so that they are added to that branch.

seliv55 commented 6 years ago

@pcm32 , OK, thanks Pablo, I am going now to install minicube in my PC and check if it works with Galaxy. I'll let you know.

sneumann commented 6 years ago

This is superseded by #179