phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

Feature/add simid #179

Closed seliv55 closed 6 years ago

seliv55 commented 6 years ago

SIMID is a new tool, written in R, designed for primary analysis of raw data recorded for a great variety of metabolites by mass spectrometers in SIM (selected ion monitoring) mode and saved in netCDF files. It evaluates the peaks of mass isotopomer distribution (MID) of metabolites of interest using the provided netCDF files and a simple text file containing a short description of the characteristics allowing to localize in the records the metabolites of interest.

pcm32 commented 6 years ago

Thanks Vitaly! Could you please confirm that:

Thanks!

pcm32 commented 6 years ago

Can I suggest as well that you add a workflow file to workflows/ with an appropiate name, that shows the use of simid with the other tools? Thanks!

seliv55 commented 6 years ago

Thanks Pablo for reviewing it!

Yes, I checked, it works fine with minikube.

Simid writes its output in the same format as Ramid or cdf2mid, so It should be compatible with midcor, but I have to check it.

I will do it.

Vitaly

On 04/04/2018 02:11 PM, Pablo Moreno wrote:

Thanks Vitaly! Could you please confirm that:

Thanks!

seliv55 commented 6 years ago

OK, good, I will do it. Thanks for this suggestion. Vitaly

On 04/04/2018 02:13 PM, Pablo Moreno wrote:

Can I suggest as well that you add a workflow file to workflows/ with an appropiate name, that shows the use of simid with the other tools? Thanks!

pcm32 commented 6 years ago

Hi @seliv55! Any chance of adding the workflow using simid to this PR? Thanks!

seliv55 commented 6 years ago

Hi @pcm32! Thanks for your concern and help! There is no problem to connect simid with midcor; they are connected. There are two problems in connection with Isodyn. First, since the CDF files analyzed with simid contain many metabolites, some of them are not recorded well by the MS machine. We discussed this with our experimental team, and they say that it makes no sense to pass all the automatically corrected data to simulation by Isodyn. The corrected data should be manually selected before the simulation step. The output of midcor should be made convenient to facilitate the manual selection and corresponding editing, whereas the currently used format is very inconvenient. So, I made the output of midcor convenient for manual checking. The input for Isodyn I adjusted correspondingly. So, this is done, but in this way, the workflow is restricted by the two first steps: simid-midcor. Simulation normally takes much more attention than the first steps of data preparation and we think that better not to connect it in the automatic workflow, but keep Isodyn as a separate tool. Are you agree? Nevertheless Isodyn accepts the output of midcor and ane selection of data from it without additional editing. Second, the data, which I have now as an example for simid, contain more than one GCMS fragment of each metabolite. Isodyn was designed for the simulation of mass isotopomers in only one fragment of each metabolite. Now I am changing the design of Isodyn, so that to make it able to simulate the mass isotopomers in various fragments. Hope to finish this soon.

sneumann commented 6 years ago

Do we need this to be merged for tomorrows demo ? Can the demo show the two parts 1) simid-midcor, and after manual curation Isodyn ? Yours, Steffen

djcomlab commented 6 years ago

Any updates expected for this?

seliv55 commented 6 years ago

Sorry, David.

Finally we used the improvements developed as "simid" to upgrade "Ramid" and "cdf2mid". Simid itself has some additional useful functionality, but we would like to improve its communication with the existing workflow and implement it in PhenoMeNal later, during the period of maintenace.

On 06/22/2018 05:25 PM, David Johnson wrote:

Any updates expected for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/phnmnl/container-galaxy-k8s-runtime/pull/179#issuecomment-399479915, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ALxXFFkiLwGyuF3_tZPVAJxEsgVvFyLIks5t_QyAgaJpZM4TGiAV.

Aquest missatge, i els fitxers adjunts que hi pugui haver, pot contenir informació confidencial o protegida legalment i s’adreça exclusivament a la persona o entitat destinatària. Si no consteu com a destinatari final o no teniu l’encàrrec de rebre’l, no esteu autoritzat a llegir-lo, retenir-lo, modificar-lo, distribuir-lo, copiar-lo ni a revelar-ne el contingut. Si l’heu rebut per error, informeu-ne el remitent i elimineu del sistema tant el missatge com els fitxers adjunts que hi pugui haver.

Este mensaje, y los ficheros adjuntos que pueda incluir, puede contener información confidencial o legalmente protegida y está exclusivamente dirigido a la persona o entidad destinataria. Si usted no consta como destinatario final ni es la persona encargada de recibirlo, no está autorizado a leerlo, retenerlo, modificarlo, distribuirlo o copiarlo, ni a revelar su contenido. Si lo ha recibido por error, informe de ello al remitente y elimine del sistema tanto el mensaje como los ficheros adjuntos que pueda contener.

This email message and any attachments it carries may contain confidential or legally protected material and are intended solely for the individual or organization to whom they are addressed. If you are not the intended recipient of this message or the person responsible for processing it, then you are not authorized to read, save, modify, send, copy or disclose any part of it. If you have received the message by mistake, please inform the sender of this and eliminate the message and any attachments it carries from your account.