search

phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

Updates to isatools tools #215

Closed djcomlab closed 6 years ago

djcomlab commented 6 years ago

Various updates to isatools related tools, in preparation for tool freeze for v18.01-dalcotidine release.

djcomlab commented 6 years ago

Note I will fix the container version numbers when pulling into the release branch (latest is currently easier for develop purposes).

c-ruttkies commented 6 years ago

Can you add resources="all" to the line where you defined tool id="mtbls-labs-uploader" destination="dynamic-k8s-small" in job_conf.xml? I think this was necessary.

djcomlab commented 6 years ago

Thanks @c-ruttkies, well spotted!

pkrog commented 6 years ago

Hi @djcomlab , what's the link with PR #220 ?

djcomlab commented 6 years ago

This should go into develop but also into the D-release branch. #220 fixes container versions for the release. I like to leave my containers to latest in develop for ease of testing/development when I need to make updates to the containers.

pcm32 commented 6 years ago

Release branch will be merged (when releasing) to develop, so it will make it to develop eventually. You should merge to develop (and not the release) if you dont't want something on the release, but for the next one. Not sure you should merge to both, goes against the release branching pattern.

ilveroluca commented 6 years ago

This looks ok to me. Galaxy starts up fine and doesn't report any errors. I haven't done any more in-depth testing, but I'm sure @djcomlab has :-)

djcomlab commented 6 years ago

Thanks @ilveroluca ... I had one more fix just committed. Now I'm done!

djcomlab commented 6 years ago

Ahh @proccaserra spotted some other small bugs so won't merge it quite yet!