search

phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

Feature/tool update/mtbls dwnld factor slicing #227

Closed pkrog closed 6 years ago

pkrog commented 6 years ago

Upgrade mtbls-dwnld with factor slicing feature. Merged Aspera ascp networking help notice.

pcm32 commented 6 years ago

Great! This should be merged to the release branch, not develop, unless that you don't want it for the release.

c-ruttkies commented 6 years ago

@pkrog can you add a proper release tag other than 'latest' for the container in config/phenomenal_tools2container.yaml?

pkrog commented 6 years ago

I've just changed the base to the release branch, and will make some tests on my local computer now.

pkrog commented 6 years ago

Tag added to config/phenomenal_tools2container.yaml. I've tested it, and it works. We can merge. Does the Codacy test failure still means nothing? I've clicked on it but didn't understand a thing.

djcomlab commented 6 years ago

@pkrog Yeah, I'm pretty sure the Codacy checks not running isn't a problem. It looks like because the diffs are on non-code files, Codacy decides to do nothing.