search

phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

sib/v18.01 dalcotidine #231

Closed rrueedi closed 6 years ago

rrueedi commented 6 years ago

Changes for iterative-signature-algorithm and metabomatching tools for dalcotidine release.

rrueedi commented 6 years ago

metabomatching itself changed (docker_tag_override: v0.2.1_cv0.5.67) but there was no need to change the Galaxy wrapper.

pkrog commented 6 years ago

Hi @rrueedi , yes we understand that only the container tag has been updated for metabomatching, however for the sake of clarity, as stated by @korseby , could you please make another pull request (hence from another branch) for the metabomatching container tag upgrade, and remove that line from this iterative-signature-algorithm PR?

korseby commented 6 years ago

The release of metabomatching will be done by @c-ruttkies :)

c-ruttkies commented 6 years ago

There's already a stable release tag for dalcotidine as stated by @rrueedi (v0.2.1_cv0.5.67). So what needs to be done here @pkrog ?

rrueedi commented 6 years ago

I'm not sure, but I created new pull requests to separate changes related from metabomatching [#237] and iterative-signature-algorithm [#238].