search

phnmnl / container-galaxy-k8s-runtime

PhenoMeNal runtime for Galaxy running inside a container orchestrator
Apache License 2.0
5 stars 18 forks source link

hotfix/fix assay table rendering in ISA-Tab Viewer plugin #276

Closed djcomlab closed 6 years ago

djcomlab commented 6 years ago

Fixes multiple assay table rendering #270 in ISA-Tab Viewer visualization plugin.

Additionally cleans up the presentation a bit. Works very nicely in Galaxy scratchbook.

pkrog commented 6 years ago

Tested on minikube with MTBLS9. The two assays were visible.

ilveroluca commented 6 years ago

While the test passed, I think typeof returns a string, so we should be comparing to the string 'undefined'. Instead on lines 55, 61, 115 we have comparisons like:

            if (typeof __ret !== undefined) {

Other times the new code compares to the string 'undefined' (lines 174, 179 and 190).

My Javascript knowledge is minimal so I'm now saying this won't work @djcomlab . It does look incoherent though.

djcomlab commented 6 years ago

@ilveroluca I think you mean inconsistent!

ilveroluca commented 6 years ago

Thanks for the correction :-)

djcomlab commented 6 years ago

I've made the correction, someone please review again...