Config clean code needed

pho-incubator / pho-server-php

Pho is an open source online community platform.

http://www.phonetworks.org

GNU Affero General Public License v3.0

1 stars 0 forks source link

Open esokullu opened 7 years ago

esokullu commented 7 years ago

in configs/app.development.php why we need a variable like DB_DYNAMODB_IS_LOCAL while we can just look up if it is localhost or 127.0.0.1 instead...
Also we need one type of variables for both mysql and dynamo makes more sense.

The bottomline is CLEAN CODE VERY IMPORTANT!

ksolotl commented 7 years ago

If we have variable like DB_DYNAMODB_IS_LOCAL we can quickly switch our DB from localhost to Amazon. I think it's useful.