search

phoboslab / Impact

HTML5 Game Engine
MIT License
2k stars 201 forks source link

Unused variable in ig.Music #13

Closed Joncom closed 5 years ago

Joncom commented 5 years ago

https://github.com/phoboslab/Impact/blob/f461c2f4054dac37dea351d8fe3440eae6a2f47e/lib/impact/sound.js#L211

This variable doesn't get used anywhere.

Joncom commented 5 years ago

The variable fadeTimer should probably be renamed to _fadeTimer to match the original intent, and to be consistent with the naming convention used by all the other related private variables.

https://github.com/phoboslab/Impact/blob/f461c2f4054dac37dea351d8fe3440eae6a2f47e/lib/impact/sound.js#L338

gamecubate commented 5 years ago

See #20

EDIT spareTimer... coding without coffee was such a good idea... Now fixed (i.e., _fadeTimer).

gamecubate commented 5 years ago

Can you do the merge and close this issue?

EDIT New PR. #24