search

phoboslab / Impact

HTML5 Game Engine
MIT License
2k stars 201 forks source link

Tests? #2

Closed dey-dey closed 6 years ago

dey-dey commented 6 years ago

Hey! I didn't see any tests, do you have a plan/opinion on how to start testing it?

SHADOWELITE7 commented 6 years ago

It was already tested. He has created some games in it. http://impactjs.com/

image

stepanvanzuriak commented 6 years ago

@SHADOWELITE7 I'ts about testing like Unit testing

Why should I spend more time on writing tests if my code seems to work fine? The answer is simple, it makes you think and reason better, as well as keeps your code easier to maintain and improves its accuracy. https://codeburst.io/testing-your-javascript-code-95c171c71647

SHADOWELITE7 commented 6 years ago

o I see :+1:

SHADOWELITE7 commented 6 years ago

makes sense since I knew the engine since I was 13 which was 4 years ago

gamecubate commented 6 years ago

I've been using ImpactJS for years now and I'm pretty sure that all bugs were ironed out long ago. New code or modules would benefit from TDD for sure, but the original stuff, not so much and I see no benefit for this. Just an opinion.

SHADOWELITE7 commented 6 years ago

what is TDD

gamecubate commented 6 years ago

TDD = test-driven development

SHADOWELITE7 commented 6 years ago

thx