search

phoboslab / JavaScriptCore-iOS

Apple's JavaScript Engine, with modified project files for iOS
695 stars 166 forks source link

armv7s #1

Closed jonasman closed 10 years ago

jonasman commented 11 years ago

is there any compiled version for simulator, amrv7 and armv7s?

phoboslab commented 11 years ago

No. It's compiled with a Simulator and armv7 slice only. As far as I can tell, there was no speed improvement with the armv7s slice, so I rather opted for the smaller binary size.

The WTF and JSC libs should compile without problems with the added armv7s slice, though.

jonasman commented 11 years ago

I had hard time trying to compile it. I need 7s otherwise my project is. Not optimized for 7s. I have many libs and it would be nice to have 7 and 7s compatibility.

Enviado do meu iPhone

No dia 13/12/2012, às 18:19, "Dominic Szablewski" notifications@github.com escreveu:

No. It's compiled with a Simulator and armv7 slice only. As far as I can tell, there was no speed improvement with the armv7s slice, so I rather opted for the smaller binary size.

The WTF and JSC libs should compile without problems with the added armv7s slice, though.

— Reply to this email directly or view it on GitHub.

phoboslab commented 11 years ago

Do you have any benchmarks of armv7 vs. 7s? I'm curious if there's really a measurable performance difference. Information about 7s everywhere is pretty vague, but I was under the assumption that very little has changed.

wcwynn commented 11 years ago

If you want to build this on your own, follow the compile instructions on the README.md page but before doing so, make the following to the two changes to the xcode projects:

  1. Add armv7s to the WTF iOS target Valid Architectures and in the Build Active Architecture Only section, set Release to No
  2. Add armv7s to the JavaScriptCore iOS target Valid Architectures and in the Build Active Architecture Only section, set Release to No

I built a version with armv7s here: https://github.com/wcwynn/phonegap-plugin-wizViewManager/blob/libjavascriptcore-update/ios/project/Plugins/WizViewManagerPlugin/JavaScriptCore/libJavaScriptCore.a

It should be good to go.

myster-t commented 11 years ago

@wcwynn Thanks for your build, I'm testing it out as we speak!

I tried to go through the compilation steps for armv7s, but I got stuck with an error for a missing LLIntAssembly.h.

wcwynn commented 11 years ago

This issue has been open for a while. Since I had to rebuild for typedarray support so here are some pull requests that address this issue.

https://github.com/phoboslab/JavaScriptCore-iOS/pull/2 https://github.com/phoboslab/JavaScriptCore-iOS/pull/3