search

phoboslab / JavaScriptCore-iOS

Apple's JavaScript Engine, with modified project files for iOS
695 stars 166 forks source link

Doesn't compile for arm64 #15

Closed martijnthe closed 10 years ago

martijnthe commented 10 years ago

I think the version of JavaScriptCore has an incomplete implementation for arm64. Running into all kinds of missing pieces when compiling with ARCHS=arm64.

Is there an easy way to pull the source in from a newer version? What files should be kept?

phoboslab commented 10 years ago

Unfortunately the process to get JSC compiled for iOS is quite a mess and changes with each JSC version. The only documentation I have of this is the commit log of the repo.

I usually don't keep any of the old files, start from a fresh JSC version and add my own fixes (typed array API https://github.com/phoboslab/JavaScriptCore-iOS/commit/ee9d2ce6d6032c887f621d22c1f06078a13f6c3b and the MIN_VALUE fix https://github.com/phoboslab/JavaScriptCore-iOS/commit/850e64267ada34b296df359cde1f934b628d0e4f ) on top again. The main steps are adding targets to the XCode project for iOS, fixing some paths and removing private API usage.

I can look into this a bit more on the weekend.

phoboslab commented 10 years ago

Current version compiles for armv7, armv7s, arm64 and the simulator. Thanks @martijnthe!

(Also see #1, #2, #3)

martijnthe commented 10 years ago

You're welcome! Glad it worked out so quickly :)