search

phoboslab / jsmpeg-vnc

A low latency, high framerate screen sharing server for Windows and client for browsers
2.37k stars 394 forks source link

Sound?? #62

Open bionichuman opened 5 years ago

bionichuman commented 5 years ago

Does sound work yet?? Trying to watch a video using this but sound does not seem to come through. Does sound work?

callTx commented 5 years ago

Jsmpeg-vnc has not a JavaScript sound decoder implemented as far I know. I'm going to implement the js sound decoder and do a pull request.

I needed a js browser video and sound decoder some year ago but I didn't found out.

bionichuman commented 5 years ago

Cool, please let me know when you do. I am trying to just unblock Netflix through a web proxy or this. If you have any ideas for that please let me know too.

callTx commented 5 years ago

What do you mean unblock Netflix with proxy?

bionichuman commented 5 years ago

@eipeipkrop7992 Access netflix via a web proxy.

BelleNottelling commented 5 years ago

Just a comment about this, but jsmpg-vnc isn't very secure for that. I'm assuming you'll be opening a port to outside connections which will let anyone who has the IP address to your VNC to control your computer, also, there's no SSL so your passwords, usernames, credit card information, ect could be easily obtained if someone was trying

edit: you can also see here that jsmpeg does indeed have audio decoding in newer versions, so it's a matter of capturing, encoding, and sending audio on the server and updating the version of jsmpeg used

callTx commented 5 years ago

Yeap I saw that. That is a MP2 decoder. Actually only in Jsmpeg-vnc repo it isn't not implemented. I will need to code sound grabber and encode that. It's not difficult. All this things is on my to-do list.

BelleNottelling commented 5 years ago

Hey @eipeipkrop7992 any progress at implementing audio?

callTx commented 5 years ago

Hi.

I'm at uni. I'm finishing my final thesis, so until January i will be busy.

On Tue, Nov 6, 2018, 6:17 AM Ben notifications@github.com wrote:

Hey @eipeipkrop7992 https://github.com/eipeipkrop7992 any progress at implementing audio?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phoboslab/jsmpeg-vnc/issues/62#issuecomment-436183051, or mute the thread https://github.com/notifications/unsubscribe-auth/AjFtVgB_E4GlqVQVMOJF_sQDCXOK72KUks5usVOagaJpZM4WOvjq .

kitsonliu-dev commented 5 years ago

May I know if there are any updates for the sound grabber? I think your project is very interesting.

callTx commented 5 years ago

Hey,

Grab sound is not difficult. You can grab the whole desktop sound via drive or grab it hooking the process buffer. Use a few FFmpeg parameters to encode it and after decode using a js decoder. Then merge into jsmpeg. I'll try to find out a free time to implement this project.

Em qua, 10 de jul de 2019 às 16:40, kitsonGit notifications@github.com escreveu:

May I know if there are any updates for the sound grabber? I think your project is very interesting.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phoboslab/jsmpeg-vnc/issues/62?email_source=notifications&email_token=AIYW2VQFJXMVXCQK6KZI3N3P6Y3J3A5CNFSM4FR27DVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZUQPLI#issuecomment-510199725, or mute the thread https://github.com/notifications/unsubscribe-auth/AIYW2VTNUGENJISUXA2CBFDP6Y3J3ANCNFSM4FR27DVA .

kitsonliu-dev commented 5 years ago

Hey,

It is found that my FFmpeg can only find recorder devices instead of playback devices. Then I use a VB virtual cable to redirect the sound to a virtual recorder device. The sound can be captured.

after following the instruction of "https://github.com/phoboslab/jsmpeg" I can stream the desktop with sound now.

I do not have much knowledge about c program. Hope it can give you some ideas for future improvement.

Thanks

thejammie9 commented 4 years ago

Hey,

It is found that my FFmpeg can only find recorder devices instead of playback devices. Then I use a VB virtual cable to redirect the sound to a virtual recorder device. The sound can be captured.

after following the instruction of "https://github.com/phoboslab/jsmpeg" I can stream the desktop with sound now.

I do not have much knowledge about c program. Hope it can give you some ideas for future improvement.

Thanks

Would you be able to list how you managed to do it as i was reading what you read and it makes zero sense to me so i hint into the right direction would be awesome

Thanks!