search

phoboslab / qoi

The “Quite OK Image Format” for fast, lossless image compression
MIT License
6.92k stars 330 forks source link

Roundtrip failure on images/pngimg/viber_PNG2.png? #158

Closed aldanor closed 2 years ago

aldanor commented 2 years ago

I've tried to the reference C implementation on the big benchmark suite, verifying whether the data roundtrips, and noticed one failure - it's the images/pngimg/viber_PNG2.png file (attached).

Could someone confirm whether it fails indeed, or is it something on my side?

viber_PNG2

phoboslab commented 2 years ago

Works fine for me. The memcmp() in qoibench.c finds no difference after en- & decoding.

Did you modify the source? How did you compile the qoibench.c? On what OS and CPU? It might still be a problem with this implementation when compiled for different environments.

aldanor commented 2 years ago

@phoboslab Yep, indeed, my bad - that file is 16-bit and stb is auto-converting it to 8-bit which should be done manually with other decoders.