search

phocean / TopIcons-plus

An gnome-shell extension to put the icons back to the tray.
678 stars 98 forks source link

Deprecated api object.actor #137

Closed xambroz closed 4 years ago

xambroz commented 4 years ago

Hello, the TopIcons is using deprecated API of object.actor. This is what I see in the journal:

Nov 21 00:59:13 localhost.localdomain gnome-shell[2182]: Usage of object.actor is deprecated for ButtonBox
                                                         get@resource:///org/gnome/shell/ui/environment.js:249:29
                                                         destroyTray@/usr/share/gnome-shell/extensions/TopIcons@phocean.net/extension.js:201:5
                                                         disable@/usr/share/gnome-shell/extensions/TopIcons@phocean.net/extension.js:76:9
                                                         _callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:78:13
                                                         _onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:406:13
                                                         _onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:403:9
xambroz commented 4 years ago 
Nov 21 01:12:26 localhost.localdomain gnome-shell[2182]: Usage of object.actor is deprecated for ButtonBox
                                                         get@resource:///org/gnome/shell/ui/environment.js:249:29
                                                         destroyTray@/usr/share/gnome-shell/extensions/TopIcons@phocean.net/extension.js:201:5
                                                         disable@/usr/share/gnome-shell/extensions/TopIcons@phocean.net/extension.js:76:9
                                                         _callExtensionDisable@resource:///org/gnome/shell/ui/extensionSystem.js:78:13
                                                         _disableAllExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:498:17
                                                         _disableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:497:13
                                                         _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:515:13
                                                         _emit@resource:///org/gnome/gjs/modules/signals.js:135:27
                                                         _sync@resource:///org/gnome/shell/ui/sessionMode.js:205:9
                                                         pushMode@resource:///org/gnome/shell/ui/sessionMode.js:167:9
                                                         activate@resource:///org/gnome/shell/ui/screenShield.js:1269:17
                                                         lock@resource:///org/gnome/shell/ui/screenShield.js:1318:9
                                                         _onStatusChanged/this._lockTimeoutId<@resource:///org/gnome/shell/ui/screenShield.js:844:21
phocean commented 4 years ago

Thank you for letting me know. I will keep an eye on it but don't want to break older versions (Debian users :)

rannbaron commented 4 years ago

This is creating lots of spam in the journalctl log on my Debian unstable system. Any chance it could be fixed for the 3.36 version?

phocean commented 4 years ago

Yes, when I have time to work on this.

phocean commented 4 years ago

It should be fixed, I removed the deprecated method: no warning or issue so far. Wait for the update to reach the Gnome website and that should be fine. Re-open if necessary.