phocean / TopIcons-plus

An gnome-shell extension to put the icons back to the tray.
678 stars 98 forks source link

Makefile produces error #143

Closed patatahooligan closed 4 years ago

patatahooligan commented 4 years ago

I get the following error when building the package via the aur's PKGBUILD

cp -P -p locale schemas convenience.js extension.js metadata.json prefs.js README.md _build
cp: -r not specified; omitting directory 'locale'
cp: -r not specified; omitting directory 'schemas'

It seems that the displayed line in the Makefile is missing an -r option, or it shouldn't be trying to copy those directories. Judging from the file's history it's the former, it's a typo that should be changed like so

diff --git a/Makefile b/Makefile
index 68fcae1..d1f4d7b 100644
--- a/Makefile
+++ b/Makefile
@@ -13,7 +13,7 @@ install: build
 build: compile-schema
    rm -rf _build
    mkdir _build
-   cp -P -p locale schemas convenience.js extension.js metadata.json prefs.js README.md _build
+   cp -R -p locale schemas convenience.js extension.js metadata.json prefs.js README.md _build
    echo Build was successful

 compile-schema: ./schemas/org.gnome.shell.extensions.topicons.gschema.xml
phocean commented 4 years ago

Ho shit, that's a typo that I introduced in the last commit. I should go to sleep :) That should be fixed now.

Thank you for your quick report!