search

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
79 stars 30 forks source link

WD triangular mesh has some degenerate triangles #53

Closed horvatm closed 6 years ago

horvatm commented 8 years ago

The triangular mesh generated from WD surface discretization has some triangles with zero area, which could affect algorithms using them.

aprsa commented 8 years ago

How dire is this? I can fix it more-or-less straightforwardly, but it will mess up the 1:1 analogy with WD.

horvatm commented 8 years ago

It can be only a problem, if this is not expected. If WD mesh won't be used with other libphoebe routines then this is irrelevant. @kecnry can you comment on this.

kecnry commented 8 years ago

I don't see any problems with the zero-area triangles. Libphoebe's eclipsing fails on WD-meshes for many other and bigger reasons, and I haven't seen any of the other routines running into issues.

In the end, these triangles are ignored in the integration anyways because they have zero area, so as long as they don't cause a complete crash, I don't think its worth putting effort into fixing it and having to handle the exception when comparing meshes vs WD.

horvatm commented 8 years ago

Then I will relabel this into annoyance.

horvatm commented 6 years ago

This is not needed anymore in Phoebe 2.x