matplotlib compatibility issues

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software

http://phoebe-project.org

GNU General Public License v3.0

80 stars 30 forks source link

matplotlib compatibility issues #636

Open kecnry opened 2 years ago

kecnry commented 2 years ago

matplotlib 3.5.2 breaks colorbars/sidebars with the following traceback:

  1446 fig = parents[0].get_figure()
   1448 pad0 = 0.05 if fig.get_constrained_layout() else loc_settings['pad']
   1449 pad = kw.pop('pad', pad0)

AttributeError: 'tuple' object has no attribute 'get_figure'

matplotlib 3.6 with a GTK backend breaks default plotting cases (see #637)
matplotlib 3.7.2 (or sooner) breaks when attempting to draw axvlines (see #881).

MichaelAbdul-Masih commented 1 year ago

When trying to run

b.plot(solution='lcgeom_solution', show=True)

after running the LC geometry estimator (from the 2023 workshop tutorial(12), an error is thrown and the eclipse edges are not plotted.

numpy.__version__ = 1.24.3
matplotlib.__version__ = 3.7.1

EDIT: it appears that downgrading to matplotlib 3.5.1 does not work, but downgrading numpy to 1.23.1 does solve the issue so perhaps this is a numpy issue.