search

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
80 stars 30 forks source link

Server-side fix for the missing supporting tables #707

Closed aprsa closed 1 year ago

aprsa commented 1 year ago

This fix corrects the packing of supporting tables for the upcoming 2.5 release.

kecnry commented 1 year ago

I added instructions to the passband server for how to test locally. Before merging, one of us will need to test that this works as expected to fix the failing test in #706 by running the server on this branch, and a local version of phoebe (in a separate environment) with both 2.4.x and the branch from #706, with the local versions of TESS:T and Johnson:R removed, and make sure the files are hosted and parsed correctly in both cases.

Assuming that passes, this can make the next bugfix release, and then we will need to update the version running on the passband server itself to the new bugfix, and then CI should hopefully pass :crossed_fingers:. I don't think this necessarily needs to hold up #706 though - we can either move forward with that in the meantime and just manually check CI logs to make sure that is the only failing test on other PRs or temporarily changes those tests to use the shipped passbands.

aprsa commented 1 year ago

Checks are now passing on the updated server, and everything I tried on my end (with phoebe 2.4) works as expected. We should test on phoebe 2.2 and 2.3, and then I think this is ready to go in.