phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
80 stars 30 forks source link

rv_geometry estimator cannot automatically flip for asini@star for SB1 case #758

Open kecnry opened 1 year ago

kecnry commented 1 year ago

When the input data is an SB1, the rv_geometry estimator proposes asini@star instead of asini@binary, but as of 2.4.11 (https://github.com/phoebe-project/phoebe2/pull/729) can no longer automatically handle flipping the constraint to adopt the proposed value. In this case, since q is also proposed, the logic could exclude q from being a valid option and still automatically flip for sma@binary. In the general case, we could support passing the temporary flip for options as a dictionary to adopt_solution.