search

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
76 stars 28 forks source link

Fixes the spuriously failing "test_rm" test. #787

Closed aprsa closed 8 months ago

aprsa commented 8 months ago

This was due to the numerical instability that was caused by computing RVs precisely at conjunctions of precisely identical stars except for sub/super-synchronous rotation. Fixed by making the secondary slightly smaller and, for good measure, slightly less massive. Closes #689.

kecnry commented 8 months ago

It looks like this includes #786 but is also needed in order for the tests to pass, is that right? Can we split out so this is just the RV test fix and then we can do this one before the other? Alternatively, we could consider them both together here and just close out #786.

aprsa commented 8 months ago

I'd just do both at the same time, because that opens the path for nodistutils to be merged in.