phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
76 stars 28 forks source link

dynamical RVs should not need calls to atmosphere tables #812

Closed kecnry closed 4 months ago

kecnry commented 6 months ago
import phoebe
b = phoebe.default_binary()
b.add_dataset('rv', compute_times=[0, 0.1])
b.set_value_all('rv_method', 'dynamical')
b.set_value_all('teff', 100000)
b.run_compute()

raises an error from atmosphere tables (or limb-darkening lookup) being out-of-bounds.... but so long as meshes are not required to be populated, or passband scaling to be used, PHOEBE should not need to make any calls to the atmosphere tables.

See https://github.com/phoebe-project/phoebe2/discussions/809#discussioncomment-7837270 for more details.