search

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
79 stars 30 forks source link

run_checks_compute() bugfix #837

Closed aprsa closed 6 months ago

aprsa commented 6 months ago

The run_checks_compute() function included the internal "_default" compute parameter set in checking the ck2004 model atmosphere table existence in the passband files. This caused the checks to fail even if ck2004 was never needed.

aprsa commented 6 months ago

Note that this fix had to be applied to the blending-dev branch so that other commits can be tested/applied.

kecnry commented 6 months ago

We will also need to make sure to update any changes made to #826 so changes made during review here are not later reverted.

aprsa commented 6 months ago

Any place we can add a quick regression test?

It's implicitly tested in the blackbody extinction test in PR #826, so we do have coverage.

kecnry commented 6 months ago

It's implicitly tested in the blackbody extinction test in PR https://github.com/phoebe-project/phoebe2/pull/826, so we do have coverage.

We'll have coverage whenever that is released... but I guess its unlikely this will be reintroduced, especially with the comment explaining the reason for using the default checks.

aprsa commented 6 months ago

Thanks! Just for peace of mind - can you please copy this finalized version over to the other branch and confirm that it passes the test coverage there before we merge?

Yep, it passes. Merge away.