lc_geometry propose compute_phases to cover eclipses more heavily

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software

http://phoebe-project.org

GNU General Public License v3.0

76 stars 28 forks source link

Open kecnry opened 2 weeks ago

kecnry commented 2 weeks ago

Original algorithm written by @piotrkolaczekszymanski and @amiszuda

TODO:

[ ] Current test example is proposing compute_phases of [0, 1] which is clearly incorrect. Investigate this.
[ ] Test coverage
[ ] Documentation

amiszuda commented 2 weeks ago

It is actually an algorithm originally written by Piotr Kołaczek-Szymański (not on GitHub) with some changes.

kecnry commented 2 weeks ago

Ah yes, I'm in the room with new GitHub user @piotrkolaczekszymanski right now 😂

aprsa commented 2 weeks ago

It is actually an algorithm originally written by Piotr Kołaczek-Szymański (not on GitHub) with some changes.

Wrong, we got him onto github a few days ago! :)