Updated functionality for lnf_rv

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software

http://phoebe-project.org

GNU General Public License v3.0

79 stars 30 forks source link

Updated functionality for lnf_rv #901

Closed kmhambleton closed 1 month ago

kmhambleton commented 3 months ago

Updated _calculate_cf function to adjust lnf calculation for radial velocities. The noise nuisance parameter for rvs no longer contains the rv amplitude.

Closes #752 and #895

TODO:

[ ] update documentation to mention change (and remove in release-2.5 branch)
[x] add warning when using lnf with rv to mention change in behavior (and remove in release-2.5 branch)

kecnry commented 3 months ago

looks like the base bugfix branch (#907) is also failing CI, so likely due to upstream changes. We can move forward with this if those errors are all the same, but then should probably try to get CI passing again before releasing.

kecnry commented 1 month ago

Confirmed that the failing tests were the same as on the base branch. @kmhambleton does the warning I added look reasonable to you (since this is a behavior change and we want to make sure anyone that was relying on the old behavior for some reason will see this change - we can remove the warning in the next minor release)?