search

phoebe-project / phoebe2

PHOEBE - Eclipsing Binary Star Modeling Software
http://phoebe-project.org
GNU General Public License v3.0
76 stars 28 forks source link

Adding back the definition of self.wl to passband load() function #914

Closed Raindogjones closed 5 days ago

Raindogjones commented 6 days ago

At some point (I haven't managed to track down when), the definition of self.wl disappeared from the passband load() function. This means that already created passbands cannot be built upon and needed to be initialised from scratch, i.e.

pb=phoebe.get_passband("Johnson:V")
pb.compute_blackbody_response()

will fail, even though the passband includes all the required information to recalculate the blackbody response.

kecnry commented 6 days ago

What version/branch of phoebe does this affect (so we can update the merge target to match)?

Raindogjones commented 6 days ago

It affects the release branch, looks like it might go all the way back to the 2.2.0 release!

kecnry commented 5 days ago

Ok, I retargeted to the bugfix branch. Can you write a snippet of how you think this should be listed in the changelog for the next bugfix release? Once 2.4.15 is released, I'll then propagate this through to all other branches.

Raindogjones commented 5 days ago

"Fixed population of wavelength array in load function for passbands"?