phoenix-dataplane / phoenix

Phoenix dataplane system service
https://phoenix-dataplane.github.io
Apache License 2.0
50 stars 9 forks source link

Receiver Side ACL plugin and Chain Engines example #236

Closed livingshade closed 1 year ago

livingshade commented 1 year ago

Why are these changes needed?

This PR includes the following change:

Checks

crazyboycjr commented 1 year ago

@libertyeagle Could you double-check if the changes in src/phoenixos/src/runtime/upgrade.rs make sense to you? I think currently it implies that we should trust the engine developers to never block the runtime (given that we already trust engine developers, so it should be fine?) Would there be any other possibility that the flushing stage was blocked indefinitely?

libertyeagle commented 1 year ago

@libertyeagle Could you double-check if the changes in src/phoenixos/src/runtime/upgrade.rs make sense to you? I think currently it implies that we should trust the engine developers to never block the runtime (given that we already trust engine developers, so it should be fine?) Would there be any other possibility that the flushing stage was blocked indefinitely?

LGTM! Thanks.