Network functions for ADN

phoenix-dataplane / phoenix

Phoenix dataplane system service

https://phoenix-dataplane.github.io

Apache License 2.0

50 stars 9 forks source link

Network functions for ADN #240

Closed livingshade closed 10 months ago

livingshade commented 10 months ago

Why are these changes needed?

admission control
mutation
metrics

Related issue number

Checks

[x] I've run scripts/clippy.sh to lint the changes in this PR.
[ ] I've included any doc changes.
Testing Strategy
- [ ] Release tests
- [ ] This PR is not tested :(

livingshade commented 10 months ago

@crazyboycjr

crazyboycjr commented 10 months ago

To be honest, I'm not so sure how this can be reviewed. So my general advice is that if you've tested, you should be good to merge.

Looking at the code, I think most of them are from the load balancing feature. So maybe first fast-forward adn with main branch (if possible), then let's see what's new over that?

livingshade commented 10 months ago

So maybe first fast-forward adn with main branch (if possible)

Sorry I didn't recognize that it contains the lb functionalitiy. I will send pr that only contains lb functionality. Besides, it seems that it falls into a infinite loop when compiling mRPC and it takes 5hours, I will check that as well.

crazyboycjr commented 10 months ago

If the infinite compiling does not happen on local test, maybe trying to manually restart the CI job.